Added support for 5 Channel S0 USB Pulse meter (original: 5-kanaals S0 Pulse Meter op USB)#596
Open
Lurchi70 wants to merge 7 commits intovolkszaehler:masterfrom
Open
Added support for 5 Channel S0 USB Pulse meter (original: 5-kanaals S0 Pulse Meter op USB)#596Lurchi70 wants to merge 7 commits intovolkszaehler:masterfrom
Lurchi70 wants to merge 7 commits intovolkszaehler:masterfrom
Conversation
Adding support for S0 pulse meter from https://www.sossolutions.nl "5-kanaals S0 Pulse Meter op USB"
Adding support for S0 pulse meter from https://www.sossolutions.nl "5-kanaals S0 Pulse Meter op USB"
# Conflicts: # include/protocols/MeterSOS_S0.hpp # src/protocols/MeterSOS_S0.cpp
Collaborator
|
Interesting hardware you got there. You might add this also to ./etc/vzlogger_generic.schema.json , for generated configuration. |
++ aligned source code with clang-format ++ modified vzlogger_generic.schema.json for generated configuration ++ added send_zero parameter to sample conf file
Lurchi70
commented
Jun 30, 2023
Author
Lurchi70
left a comment
Lurchi70
left a comment
There was a problem hiding this comment.
Looks good now. Please Review.
Collaborator
|
@r00t- bump version? |
Contributor
|
thanks for your contribution, |
Author
|
Hi,
any new about this? Did you find the time for a review?
Best regards
Von: Thorben T. ***@***.***
Gesendet: Sonntag, 2. Juli 2023 09:54
An: volkszaehler/vzlogger
Cc: Lurchi70; Author
Betreff: Re: [volkszaehler/vzlogger] Added support for 5 Channel S0 USB Pulse meter (original: 5-kanaals S0 Pulse Meter op USB) (PR #596)
thanks for your contribution,
nice to see vzlogger used as a platform to support new meters,
will try to review the code next week.
—
Reply to this email directly, view it on GitHub <#596 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6IX3FBDXCASK3OGZ7IQB7TXOESIPANCNFSM6AAAAAAZWZYSWI> .
You are receiving this because you authored the thread.Das Bild wurde vom Absender entfernt.Message ID: ***@***.***>
|
Contributor
|
@Lurchi70: if you want to have it merged, i'd have some small requests:
|
r00t-
reviewed
Sep 17, 2023
| * Plaintext protocol of S0 Pulse meter devices | ||
| * --> https://www.sossolutions.nl/5-kanaals-s0-pulse-meter-op-usb | ||
| * | ||
| * The device is a USB s0 logger device. |
Contributor
There was a problem hiding this comment.
maybe just a little bit more description of the communication, at least "sending a text-based protocol over a usb-connected uart interface"?
maybe the usb-IDs used by the device or a udev rule to identify it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation a new device protocol: sos_s0
The 5 Channel S0 USB Pulse meter is a device based on Arduino Micro. It collects and buffers S0 impulse from up to five S0 devices and sends the retrieved S0-IMpulses within a 10 second timeframe to the serial port (e.g. /dev/ttyACM0) available via standard USB driver. The protocol is documented by the vendor.
The device is available here: https://www.sossolutions.nl/5-kanaals-s0-pulse-meter-op-usb
This change adds a new protocol "sos_s0" to vzlogger. The implementation opens the device port, applies the hardcoded baud rate and parity setting (9600/7/n/1) and reads the data from the serial device.
The read data is provided to volkzaehler middleware by the usual ways.